chore: add test block that duplicates on drag#2377
Merged
BeksOmega merged 1 commit intoRaspberryPiFoundation:masterfrom May 31, 2024
Merged
chore: add test block that duplicates on drag#2377BeksOmega merged 1 commit intoRaspberryPiFoundation:masterfrom
BeksOmega merged 1 commit intoRaspberryPiFoundation:masterfrom
Conversation
cpcallen
approved these changes
May 30, 2024
Collaborator
cpcallen
left a comment
cpcallen
left a comment
There was a problem hiding this comment.
Please fix lint warnings.
Is there (or will there be) a corresponding Blockly to add a test that exercises this functionality? If so, please add a comment to this PR referencing it.
Contributor
Author
|
I'm not going to fix the lint warnings. imo the code is readable and sufficient for testing. I think for test code it's allowable to ignore the warning - that's why it's not an error. ATM there's not going to be a test in core exercising this - it will just need to be manually tested. It might be possible to test this with a webdriver test? but dealing with the circular dependencies to get that working is not a high priority for me right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes N/A
Proposed Changes
Adds a test blocks that duplicates on drag so we can ensure we don't regress in support for that functionality.
Test Coverage
Tested that with my local version of Blockly the block duplicates both when it is a real block and when it is a shadow.
Documentation
N/A
Additional Information
N/A